Hi Thien, ACK from me.
Best Regards, ThuanTr -----Original Message----- From: Thien Minh Huynh <[email protected]> Sent: Tuesday, May 12, 2020 1:33 PM To: Thuan Tran <[email protected]>; Vu Minh Nguyen <[email protected]> Cc: [email protected]; Thien Minh Huynh <[email protected]> Subject: [PATCH 1/1] lgs: map the CkptPushAsync to the right memory [#3183] The standby logsv is crashed during cold sync if having pending write requests in the queue.That happens because the CkptPushAsync data for decoding is referring to wrong data. The fix is to map the CkptPushAsync to the right memory. --- src/log/logd/lgs_cache.cc | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/log/logd/lgs_cache.cc b/src/log/logd/lgs_cache.cc index e3583e97c..27e33702d 100644 --- a/src/log/logd/lgs_cache.cc +++ b/src/log/logd/lgs_cache.cc @@ -344,14 +344,10 @@ int Cache::DecodeColdSync(NCS_UBAID* uba, lgsv_ckpt_header_t* header, uint32_t num_rec = header->num_ckpt_records; int rc = NCSCC_RC_SUCCESS; EDU_ERR ederror; - lgsv_ckpt_msg_v8_t msg_v8; - auto data = &msg_v8.ckpt_rec.push_async; - CkptPushAsync* cache_data; while (num_rec) { - cache_data = data; rc = m_NCS_EDU_EXEC(&lgs_cb->edu_hdl, EncodeDecodePushAsync, uba, EDP_OP_TYPE_DEC, - &cache_data, &ederror); + vckpt_rec, &ederror); if (rc != NCSCC_RC_SUCCESS) { m_NCS_EDU_PRINT_ERROR_STRING(ederror); return rc; -- 2.17.1 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
