Summary: pyosaf: update pyosaf support python3 [#3247]
Review request for Ticket(s): 3247
Peer Reviewer(s): Thanh, Thang
Pull request to: Thang
Affected branch(es): develop
Development branch: ticket-3247
Base revision: 36c1387fe9990b84686d003f0812a33eea011b7e
Personal repository: git://git.code.sf.net/u/thienhuynh/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other y
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 2c13c9ea579dc064b1d6adcce98d62efb3d0032d
Author: thien.m.huynh <thien.m.hu...@dektech.com.au>
Date: Tue, 12 Jan 2021 17:02:49 +0700
pyosaf: update pyosaf support python3 [#3247]
- check data type before implicit type conversion
- add more encode/decode byte-string
- update iterable dict items for python 2 and 3
Complete diffstat:
------------------
python/pyosaf/saClm.py | 34 ++++++++++++++++++----------
python/pyosaf/utils/clm/__init__.py | 4 ++--
python/pyosaf/utils/immoi/agent.py | 6 ++---
python/pyosaf/utils/immoi/implementer.py | 14 ++++++------
python/pyosaf/utils/immom/agent.py | 6 +++--
python/pyosaf/utils/immom/iterator.py | 8 +++----
python/pyosaf/utils/immom/object.py | 10 ++++----
python/pyosaf/utils/ntf/subscriber.py | 7 ++++--
python/samples/imm-listener | 2 +-
python/samples/imm-listener-inheritance-impl | 2 +-
python/samples/immbase.py | 4 ++--
python/samples/immlist | 2 +-
python/samples/scale_opensaf | 2 +-
13 files changed, 58 insertions(+), 43 deletions(-)
Testing Commands:
-----------------
N/A
Testing, Expected Results:
--------------------------
N/A
Conditions of Submission:
-------------------------
ACK from reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
