Summary: log: Update the destructor and constructor of log agent [#3322]
Review request for Ticket(s): 3322
Peer Reviewer(s): Thang, Minh, Thien
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3322
Base revision: 884d9a703ac66c64b1b527856e778b4045b3e900
Personal repository: git://git.code.sf.net/u/hieuhh/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 4e1b84f156bd23965b706784a1ebd7ad0b5b4cfc
Author: hieu.h.hoang <hieu.h.ho...@dektech.com.au>
Date: Mon, 21 Nov 2022 08:59:42 +0700
log: Testcase for closing log stream in destructor [#3322]
Add a testcase for closing log stream in the destructor of a cpp object.
revision ec25bd1c91b3efa5d041ced24b5f23453cebb8ea
Author: hieu.h.hoang <hieu.h.ho...@dektech.com.au>
Date: Fri, 18 Nov 2022 11:17:41 +0700
log: Create a test case for forked processes [#3322]
Create a test case that the process running log agent is forked
to a new process.
revision cfb1e6436b0209f82ccd3d0c1989d67051b31c8e
Author: hieu.h.hoang <hieu.h.ho...@dektech.com.au>
Date: Fri, 18 Nov 2022 10:10:10 +0700
log: Update the destructor and constructor of log agent [#3322]
- The destructor of the static objects will be called in the reverse
order of constructors. If other destructors call a function of the
log agent after the destructor of the log agent, it could be crashed.
Solution is to construct the log agent object early.
- If a process is forked, both processes share all created sockets.
Cleaning resources in one process causes undefined behaviours in
other process. Solution is to empty the destructor of log agent.
Those resources are manually cleaned by the api functions of the
log agent.
Complete diffstat:
------------------
src/log/Makefile.am | 2 +-
src/log/agent/lga_agent.cc | 29 +++++---
src/log/agent/lga_agent.h | 13 +---
..._saLogStreamClose.c => tet_saLogStreamClose.cc} | 82 +++++++++++++++++++++
src/log/apitest/tet_saLogStreamOpen_2.c | 41 +++++++++++
src/log/apitest/tet_saLogWriteLogCallbackT.c | 86 ++++++++++++++++++++++
6 files changed, 234 insertions(+), 19 deletions(-)
Testing Commands:
-----------------
*** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES ***
Testing, Expected Results:
--------------------------
*** PASTE COMMAND OUTPUTS / TEST RESULTS ***
Conditions of Submission:
-------------------------
*** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC ***
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
