changeset: 4395:4a666df34b1c
branch: opensaf-4.2.x
parent: 4392:69f5d8d2001e
user: Anders Widell <anders.widell@er..>
date: Thu Aug 01 12:50:29 2013 +0200
summary: dtm: Don't use NULL pointers or uninitialized data in error paths
[#526]
changeset: 4396:cef86c3bfae0
branch: opensaf-4.3.x
parent: 4393:4266be0381c5
user: Anders Widell <anders.widell@er..>
date: Thu Aug 01 12:50:29 2013 +0200
summary: dtm: Don't use NULL pointers or uninitialized data in error paths
[#526]
changeset: 4397:b41592a3e5a6
tag: tip
parent: 4394:ce3b530cfa69
user: Anders Widell <anders.widell@er..>
date: Thu Aug 01 12:50:29 2013 +0200
summary: dtm: Don't use NULL pointers or uninitialized data in error paths
[#526]
Node ID 4a666df34b1ca5e09afaabe31aba11a57ac92dbb
Node ID cef86c3bfae0e0a0094d3564de84fc05f00d207b
Node ID b41592a3e5a6751937be77a8132430e018ad2be5
---
** [tickets:#526] dtm: Error paths use NULL pointer and uninitialized data**
**Status:** fixed
**Created:** Mon Jul 29, 2013 12:01 PM UTC by Anders Widell
**Last Updated:** Wed Jul 31, 2013 10:34 AM UTC
**Owner:** Anders Widell
If dtm_node_new() returns NULL, the call to LOG_ER() below will dereference the
returned NULL pointer. This code is in file dtm_node_sockets.c, line 1335 -
1341, tag 4.2.4RC1:
new_node = dtm_node_new(&node);
if (new_node == NULL) {
LOG_ER("DTM: dtm_node_add failed .node_ip: %s, node_id:
%u", new_node->node_ip, new_node->node_id);
dtm_comm_socket_close(&new_conn_sd);
goto node_fail;
}
Also, if inet_ntop() fails, the error message will contain the uninitialized
output buffer from from inet_ntop().
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.------------------------------------------------------------------------------
Get your SQL database under version control now!
Version control is standard for application code, but databases havent
caught up. So what steps can you take to put your SQL databases under
version control? Why should you start doing it? Read more to find out.
http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
