changeset: 5160:4f45d63e85d5
user: Hans Feldt <[email protected]>
date: Thu Apr 17 11:16:22 2014 +0200
summary: amfd: add SU susi manipulation methods [#713]
changeset: 5161:71433543f9d8
user: Hans Feldt <[email protected]>
date: Thu Apr 17 11:17:53 2014 +0200
summary: amfd: use SU method delete_all_susis [#713]
changeset: 5162:30fd01ccdca9
user: Hans Feldt <[email protected]>
date: Thu Apr 17 11:18:14 2014 +0200
summary: amfd: use SU methods for changing susis [#713]
changeset: 5163:a321898ef7b6
tag: tip
user: Hans Feldt <[email protected]>
date: Thu Apr 17 11:22:22 2014 +0200
summary: amfd: fix trailing whitespace in makefile [#713]
---
** [tickets:#713] AMF refactoring for 4.5**
**Status:** accepted
**Milestone:** 4.5.FC
**Created:** Fri Jan 10, 2014 07:05 AM UTC by Hans Feldt
**Last Updated:** Tue Apr 15, 2014 06:57 PM UTC
**Owner:** Hans Feldt
This is a 4.5 ticket for continued code re-factoring of the AMF service for
4.5. The work started with #94 in 4.4.
So far no really no C++ features has been used. Files has been renamed so that
the C++ compiler is used and new/delete is used instead of malloc/free (where
appropriate).
In this ticket it is time to make use of C++ features to get a more
maintainable and understandable code base. We should aim for many small changes
instead of few big ones.
An ordered list of things to work on:
1. Use bool which is a native type in C++ (and remove SaBoolT)
2. Reduce number of casts in the code (introduced because of C++ files)
2. Use stl::maps (instead of patricia trees)
3. Use stl::vector/list (instead of legacy/home made lists)
Other yet non prioritized items:
- Remove use of EDU and do direct encode/decode
- Clean run of google's cpplint on the code base
- Convert model derived C structs to classes and change functions into methods
- Change macros to (inline) methods
- Change bit fields (flags) to boolean attributes (see
https://sourceforge.net/p/opensaf/tickets/717/#d4b2)
- Use references instead of pointers
- ...
Non C++ related changes:
- split up long functions into smaller ones doing one things and not many
- use pmccabe complexity analysis to aid refactoring
- set a goal for pmccabe complexity
- use const as much as possible
- ...
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
