Note that I get error on warning now. Not sure which changeset introduced it:
gcc -DHAVE_CONFIG_H -I. -I../../../../.. -I../../../../../osaf/libs/saf/include -I../../../../../osaf/libs/core/include -I../../../../../osaf/libs/core/leap/include -I../../../../../osaf/libs/core/mds/include -I../../../../../osaf/libs/core/common/include -I../../../../../osaf/services/infrastructure/dtms/include -Wall -fno-strict-aliasing -Werror -fPIC -DRUNASROOT -MT osafdtmd-dtm_read_config.o -MD -MP -MF .deps/osafdtmd-dtm_read_config.Tpo -c -o osafdtmd-dtm_read_config.o `test -f 'dtm_read_config.c' || echo './'`dtm_read_config.c dtm_read_config.c: In function 'dtm_validate_listening_ip_addr': dtm_read_config.c:132:4: error: suggest parentheses around assignment used as truth value [-Werror=parentheses] cc1: all warnings being treated as errors /AndersBj Hans Feldt wrote: > - **status**: review --> fixed > - **assigned_to**: Hans Feldt --> nobody > - **Milestone**: future --> 4.3.3 > - **Comment**: > > changeset: 5994:917623d21cf6 > branch: opensaf-4.3.x > parent: 5990:0974fdd2ef70 > user: Hans Feldt <[email protected]> > date: Mon Oct 06 09:49:53 2014 +0200 > summary: dtm: fix NULL ptr dereference [#1152] > > changeset: 5995:bb58bd44d93f > branch: opensaf-4.4.x > parent: 5991:46bd98b1d43d > user: Hans Feldt <[email protected]> > date: Mon Oct 06 09:49:53 2014 +0200 > summary: dtm: fix NULL ptr dereference [#1152] > > changeset: 5996:89d33770e737 > branch: opensaf-4.5.x > parent: 5992:c01a7d0e0a15 > user: Hans Feldt <[email protected]> > date: Mon Oct 06 09:49:53 2014 +0200 > summary: dtm: fix NULL ptr dereference [#1152] > > changeset: 5997:88eeaf69642a > tag: tip > parent: 5993:d04b7c9fec97 > user: Hans Feldt <[email protected]> > date: Mon Oct 06 09:49:53 2014 +0200 > summary: dtm: fix NULL ptr dereference [#1152] > > > > > --- > > ** [tickets:#1152] osafdtmd segfaults** > > **Status:** fixed > **Milestone:** 4.3.3 > **Created:** Mon Oct 06, 2014 06:28 AM UTC by Hans Feldt > **Last Updated:** Mon Oct 06, 2014 07:17 AM UTC > **Owner:** nobody > > starting opensaf with an invalid IP address in dtmd.conf osafdtmd segafaults: > > (gdb) run -n > Starting program: /home/uabhafe/local/lib/opensaf/osafdtmd -n > [Thread debugging using libthread_db enabled] > Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". > [New Thread 0x7ffff7fd4b00 (LWP 5688)] > > Program received signal SIGSEGV, Segmentation fault. > 0x00000000004065fb in dtm_validate_listening_ip_addr > (config=config@entry=0x61b9c0 <_dtms_cb>) at dtm_read_config.c:140 > 140 if (if_addr->ifa_addr->sa_family == AF_INET) { > (gdb) info locals > if_addrs = <optimized out> > if_addr = 0x6306d0 > tmp = 0x0 > (gdb) p *if_addr > $2 = {ifa_next = 0x630788, ifa_name = 0x630774 "tun0", ifa_flags = 69841, > ifa_addr = 0x0, ifa_netmask = 0x0, ifa_ifu = {ifu_broadaddr = 0x0, > ifu_dstaddr = 0x0}, ifa_data = 0x630e00} > > > > --- > > Sent from sourceforge.net because [email protected] is > subscribed to https://sourceforge.net/p/opensaf/tickets/ > > To unsubscribe from further messages, a project admin can change settings at > https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a > mailing list, you can unsubscribe from the mailing list. > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------------ > Slashdot TV. Videos for Nerds. Stuff that Matters. > http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk > ------------------------------------------------------------------------ > > _______________________________________________ > Opensaf-tickets mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensaf-tickets > ------------------------------------------------------------------------------ Slashdot TV. Videos for Nerds. Stuff that Matters. http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-tickets mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
