- **status**: review --> fixed
- **Version**: 4.4 --> 4.5
- **Comment**:
Following are done to make MDS TCP transport sockets as BLOCKIN,which is
similar to
TIPC transport :
-Removed Non-blocking socket option on sockets (TCP transport) in MDS library
-Removed UNSENT_MSGS & it queue related code & logic
changeset: 6048:eb4147a21b4f
parent: 6045:fa8f3226802f
user: A V Mahesh <[email protected]>
date: Tue Oct 21 11:40:15 2014 +0530
summary: mds: remove O_NONBLOCK option on MDS TCP transport sockets [#607]
changeset: 6046:c312cb12ee04
branch: opensaf-4.5.x
parent: 6042:a7766e9cb310
user: A V Mahesh <[email protected]>
date: Tue Oct 21 11:38:27 2014 +0530
summary: mds: remove O_NONBLOCK option on MDS TCP transport sockets [#607]
Following are done to make DTM sockets as BLOCKIN :
-Removed Non-blocking socket option on sockets (TCP transport) in DTM
changeset: 6049:c89dd077038f
user: A V Mahesh <[email protected]>
date: Tue Oct 21 11:40:26 2014 +0530
summary: dtm: remove O_NONBLOCK option on DTM TCP transport sockets [#607]
changeset: 6047:5bf70b96105f
branch: opensaf-4.5.x
user: A V Mahesh <[email protected]>
date: Tue Oct 21 11:38:56 2014 +0530
summary: dtm: remove O_NONBLOCK option on DTM TCP transport sockets [#607]
---
** [tickets:#607] Mds : tcp assert in MDS on cumulated unsent messages**
**Status:** fixed
**Milestone:** future
**Created:** Wed Oct 30, 2013 08:03 AM UTC by A V Mahesh (AVM)
**Last Updated:** Wed Oct 15, 2014 09:23 AM UTC
**Owner:** A V Mahesh (AVM)
Using the OpenSAF test program "logtest" and the latest opensaf configured with
MDS/TCP crashes the log server in the assert in mds_mdtm_queue_add_unsent_msg():
======================================================================================
++tcp_cb->mdtm_tcp_unsent_counter; /* Increment the counter to keep a tab on
number of messages */
if (tcp_cb->mdtm_tcp_unsent_counter <= DTM_INTRANODE_UNSENT_MSG) {
if (NULL == hdr && NULL == tail) {
tcp_cb->mds_mdtm_msg_unsent_hdr = tmp;
tcp_cb->mds_mdtm_msg_unsent_tail = tmp;
} else {
tail->next = tmp;
tcp_cb->mds_mdtm_msg_unsent_tail = tmp;
/* Change the poll from POLLIN to POLLOUT */
pfd[0].events = pfd[0].events | POLLOUT;
}
} else {
syslog(LOG_ERR, " MDTM unsent message is more!=%d",
DTM_INTRANODE_UNSENT_MSG);
assert(0);
return NCSCC_RC_FAILURE;
}
======================================================================================
$ grep DTM_INTRANODE_UNSENT_MSG include/*
include/mds_dt_tcp_disc.h:#define DTM_INTRANODE_UNSENT_MSG 200
mds_mdtm_unsent_queue_add_send() is the only place
mds_mdtm_queue_add_unsent_msg() is called.
mds_mdtm_unsent_queue_add_send() can return an error code, none of its callers
check the return code! I guess it should return void then and abort internally.
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
