- **status**: review --> fixed
- **Comment**:
changeset: 6202:1ef21a586866
tag: tip
parent: 6198:474a5275d50d
user: Lennart Lund <[email protected]>
date: Tue Dec 09 12:26:20 2014 +0100
summary: log: Incorrect syslog if fail to close files when closing log
stream [#1129]
rev: 1ef21a586866c01aa4796df4dbbb197f3511bb86
changeset: 6201:c16413d2db4e
branch: opensaf-4.5.x
parent: 6196:448ba1a66163
user: Lennart Lund <[email protected]>
date: Tue Dec 09 12:26:20 2014 +0100
summary: log: Incorrect syslog if fail to close files when closing log
stream [#1129]
rev: c16413d2db4e0f33b1178a5e5f4a026ec4401ef7
changeset: 6200:6a9ec56ab3f4
branch: opensaf-4.4.x
user: Lennart Lund <[email protected]>
date: Tue Dec 09 12:26:20 2014 +0100
summary: log: Incorrect syslog if fail to close files when closing log
stream [#1129]
rev: 6a9ec56ab3f41b97d954730e310b35aff02c1d41
---
** [tickets:#1129] LOG: Incorrect syslog if fail to close files when closing
log stream**
**Status:** fixed
**Milestone:** 4.4.2
**Created:** Tue Sep 23, 2014 11:02 AM UTC by elunlen
**Last Updated:** Wed Dec 03, 2014 09:24 AM UTC
**Owner:** elunlen
In lgs_stream.c:
/* Close the log file */
rc = fileclose_h(*stream->p_fd);
*stream->p_fd = -1;
if (rc == -1) {
LOG_ER("Could not close log files: %s",
strerror(errno));
goto done_files;
}
This syslog incorrectly logs strerror(errno) which is wrong since errno is
irrelevant if fileclose_h() fails because of timeout or busy.
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
