Hi Lennart,
Please see my comment inline.
BR,
Tai Dinh
DEK Technologies Vietnam
121/137 Le Loi Street, Ben Thanh Ward,
District 1, HCM City, Vietnam
Mobile: +84 9 33 37 82 90
From: Lennart Lund [mailto:[email protected]]
Sent: Friday, January 30, 2015 3:51 PM
To: Tai Dinh C
Cc: Tai Dinh C
Subject: RE: [PATCH 0 of 1] Review Request for LOG: ownership of directories
and files should be configurable [#1181]
Hi Tai,
Sorry for a late answer but I’m quite busy with another project and I don’t
have so much time for testing right now.
Does the patch that was attached to your latest mail contain any changes
compared to the previous patch?
[Tai] The previous kept unchanged. I retested it with the UML and saw no
crashed. The only problem is that the log files could not be owned by this new
group.
The reason of this is because of something strangle with UML. Mathi is helping
to confirm it now.
So the attach patch only helps to bypass this problem.
In general the Log service (or any service) must be “immune” (no crash allowed)
to any external changes that may happen e.g.
- If log files are no longer accessible (permissions for root directory
sub directory file permissions etc. has been changed outside of log service
control)
If log records cannot be written a corresponding error code shall be given in
callback
- If changing log root directory also if setting of group name, group id,
permissions etc is incorrect
If incorrect settings changing of root directory shall not be allowed
[Tai] Currently, only error are logged into the syslog and LOG still keeps
working as before.
If users try to change root directory and group name as the same time and
either of them could not pass the verification then the whole CCB will be
aborted.
Does those look OK to you?
Other:
- Other possible external changes and IMM configurations that may be
attempted to change must be handled.
[Tai] IMM changes will be handled by callback and configuration file change
will be handle at restart if IMM is not configured
- Relevant and understandable TRACE and LOG prints shall be generated
[Tai] I put some already.
- Tests that can be run in UML environment should be created. If for some
reason (e.g. manual steps are needed) tests are not suitable to be put in the
automatic regression test suite a separate test program can be written.
[Tai] Will look into this now.
- The README file shall be updated with information not only about the
new configuration attribute but also with some description of the new feature.
The text in the README file will be used also when the programmers reference
document is updated
[Tai] I put some already.
- If new tests are created that needs some explanation this information
can be written in a README file in the test directory as well. No such README
file exist today but there is ok to add one. Another possibility is to have a
help <-h> option in the test program.
[Tai] Will look into this now.
It would be a great help if you could write tests, do some more testing and
make sure that it is not possible to crash the Log service.
[Tai] OK.
Thanks
Lennart
---
** [tickets:#1181] LOG: ownership of directories and files should be
configurable**
**Status:** review
**Milestone:** 4.6.FC
**Created:** Mon Oct 20, 2014 02:47 PM UTC by Hans Feldt
**Last Updated:** Tue Jan 20, 2015 10:39 AM UTC
**Owner:** Tai Dinh
Today LOG creates files and directories whose ownership will be that of the
primary group. LOG should support an additional group that should be used for
created directories/files. This additional group needs to be an supplementary
group for the log server process. An environment variable is enough for
configuration. There is no need to change this group in runtime.
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
