- Description has changed:

Diff:

~~~~

--- old
+++ new
@@ -1,4 +1,3 @@
-
 This in the TCP flow of MDS
 
 In the process of code walk in the context of debugging some application 
segfault, we fund on bug , USRBUF contiguous memory ( non-stranded-path system 
has vey less memory) case of fragment and send function.

~~~~

- **status**: review --> fixed
- **Comment**:

changeset:   6280:e27a46e7bcf7
branch:      opensaf-4.4.x
parent:      6270:66eff67a68ca
user:        A V Mahesh <[email protected]>
date:        Mon Feb 23 10:43:48 2015 +0530
summary:     mds/tcp: correct memcopy size of contiguous USRBUF in fragment 
send [#1247]
 
changeset:   6279:9c24654a048c
branch:      opensaf-4.5.x
parent:      6271:97ba738c12e5
user:        A V Mahesh <[email protected]>
date:        Mon Feb 23 10:43:29 2015 +0530
summary:     mds/tcp: correct memcopy size of contiguous USRBUF in fragment 
send [#1247]
 
changeset:   6278:6fce16cb0539
user:        A V Mahesh <[email protected]>
date:        Mon Feb 23 10:43:02 2015 +0530
summary:     mds/tcp: correct memcopy size of contiguous USRBUF in fragment 
send [#1247]



---

** [tickets:#1247] mds/TCP: wrong size memcpy if USRBUF chain(payload) are 
contiguous memory**

**Status:** fixed
**Milestone:** 4.6.FC
**Created:** Tue Jan 27, 2015 04:30 AM UTC by A V Mahesh (AVM)
**Last Updated:** Mon Feb 09, 2015 04:09 AM UTC
**Owner:** A V Mahesh (AVM)

This in the TCP flow of MDS

In the process of code walk in the context of debugging some application 
segfault, we fund on bug , USRBUF contiguous memory ( non-stranded-path system 
has vey less memory) case of fragment and send function.

If USRBUF chain(payload) are contiguous MMGR_DATA_AT_START doesn't copy the 
buffer , application need to copy the buffer, in that memcpy() the size was 
wrong/overflowing.

This need to be corrected as follws

@@ -2246,7 +2246,7 @@ uint32_t mdtm_frag_and_send(MDTM_SEND_RE

    memcpy(&body[SUM_MDS_HDR_PLUS_MDTM_HDR_PLUS_LEN], p8, len_buf);
    memcpy(&body[SUM_MDS_HDR_PLUS_MDTM_HDR_PLUS_LEN], p8, (len_buf - 
SUM_MDS_HDR_PLUS_MDTM_HDR_PLUS_LEN));




---

Sent from sourceforge.net because [email protected] is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

Reply via email to