The implementation of "removeSwAddRemoveDuplicates" in Rolling upgrade could 
cause a problem, since it only filters out the first duplicate pair of a 
specific add/remove duplicate from the lists.
A campaign example where the duplicates not filtered out correctly (this case 
most likely won't happen in reality):

under targetNodeTemplate within Rolling upgrade scope:
...
<swRemove bundleDN="safSmfBundle=A" pathnamePrefix="/opt/a"/>
<swRemove bundleDN="safSmfBundle=A" pathnamePrefix="/opt/a"/>
<swAdd bundleDN="safSmfBundle=A" pathnamePrefix="/opt/a"/>
...

In this case the add/remove pair will be filtered out, and the remaining 
"remove" won't be deleted from the list.


---

** [tickets:#1299] smf: redundant <swAdd> and <swRemove> entries in single step 
procedures are ignored**

**Status:** review
**Milestone:** 4.6.1
**Created:** Thu Apr 02, 2015 11:46 AM UTC by Robert Apanowicz
**Last Updated:** Wed Apr 15, 2015 06:50 AM UTC
**Owner:** Robert Apanowicz

In SmfCampaignXmlParser::parseCampaignXml() the checking is only implemented 
for the rolling procedure case where:
the redundant <swAdd> and <swRemove> entries are removed.

Single step procedures shall be treated the same way as rolling procedures.

Comments from the source code:

//For the procedure, check if the same SwBudle DN exist in both swAdd and 
swRemove lists
//In that case the SwBundle shall not be touched, remove the SwBundle DN from 
the lists.


---

Sent from sourceforge.net because [email protected] is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

Reply via email to