- **status**: review --> fixed
- **Comment**:
changeset: 6519:5ea169175607
branch: opensaf-4.5.x
parent: 6516:06883a65e1ec
user: Nagendra Kumar<nagendr...@oracle.com>
date: Wed May 06 15:24:40 2015 +0530
summary: amfd: avoid null pointer access [#1365]
changeset: 6520:03561991380d
branch: opensaf-4.6.x
parent: 6517:847c398f5243
user: Nagendra Kumar<nagendr...@oracle.com>
date: Wed May 06 15:25:19 2015 +0530
summary: amfd: avoid null pointer access [#1365]
changeset: 6521:494e23164bf0
tag: tip
parent: 6518:cb626f2b1ebd
user: Nagendra Kumar<nagendr...@oracle.com>
date: Wed May 06 15:25:28 2015 +0530
summary: amfd: avoid null pointer access [#1365]
[staging:5ea169]
[staging:035619]
[staging:494e23]
---
** [tickets:#1365] amfd: accesses null pointer during node failover**
**Status:** fixed
**Milestone:** 4.5.2
**Created:** Mon May 04, 2015 07:34 AM UTC by Nagendra Kumar
**Last Updated:** Tue May 05, 2015 11:00 AM UTC
**Owner:** Nagendra Kumar
In one of the incidences, we observed that node id was not available at amfd
data base during node failover and it logged below:
osafamfd[12539]: ER FAILOVER StandBy --> Active FAILED, node 2010f not found
----------------------
The code snap is :
if (NULL == (my_node = avd_node_find_nodeid(cb->node_id_avd))) {
LOG_ER("FAILOVER StandBy --> Active FAILED, node %x not found",
cb->node_id_avd);
goto done;
}
-----------------------
And then execution jumps to goto done, where Amfd accesses my_node, which is
null:
---------------------
done:
if (NCSCC_RC_SUCCESS != status)
opensaf_reboot(my_node->node_info.nodeId, (char
*)my_node->node_info.executionEnvironment.value,
"FAILOVER failed");
-------------------------------
This code needs some modification so that amfd doesn't access the null pointer.
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
