- **Type**: defect --> enhancement
---
** [tickets:#263] mds : Suspicios comparison**
**Status:** assigned
**Milestone:** future
**Created:** Thu May 16, 2013 08:25 AM UTC by A V Mahesh (AVM)
**Last Updated:** Thu May 16, 2013 08:25 AM UTC
**Owner:** A V Mahesh (AVM)
http://devel.opensaf.org/ticket/2639
The following comparison is always true:
(recv->snd_type != MDS_SENDTYPE_ACK) || (recv->snd_type !=
MDS_SENDTYPE_RACK)
Was the intention perhaps:
(recv->snd_type != MDS_SENDTYPE_ACK) && (recv->snd_type != MDS_SENDTYPE_RACK)
Code is found in file osaf/libs/core/mds/mds_c_sndrcv.c, line 4024:
/* For the message loss indication */
if ((true == svccb->i_msg_loss_indication) &&
((recv->snd_type != MDS_SENDTYPE_ACK) ||
(recv->snd_type != MDS_SENDTYPE_RACK) )) {
/* Get the subscription table result table function pointer */
MDS_SUBSCRIPTION_RESULTS_INFO *lcl_subtn_res = NULL;
if ( NCSCC_RC_SUCCESS ==
mds_get_subtn_res_tbl_by_adest(recv->dest_svc_hdl, recv->src_svc_id,
recv->src_vdest, recv->src_adest,
&lcl_subtn_res) ) {
if (recv->src_seq_num != lcl_subtn_res->msg_rcv_cnt) {
m_MDS_LOG_ERR
("MDS_SND_RCV: msg loss detected, Src
SVC=%d, Src vdest id= %d, Src adest=%llu, local svc id=%d msg num=%d, recvd
cnt=%d\n", recv->src_svc_id, recv->src_vdest, recv->src_adest, svccb->svc_id,
recv->src_seq_num, lcl_subtn_res->msg_rcv_cnt);
mds_mcm_msg_loss(recv->dest_svc_hdl,
recv->src_adest,
recv->src_svc_id, recv->src_vdest);
lcl_subtn_res->msg_rcv_cnt = recv->src_seq_num;
lcl_subtn_res->msg_rcv_cnt++;
} else {
lcl_subtn_res->msg_rcv_cnt++;
}
} else {
m_MDS_LOG_INFO("MDS_SND_RCV: msg loss enabled but no
subcription exists\n");
}
}
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
