- **status**: review --> fixed
- **assigned_to**: Vu Minh Nguyen --> nobody
- **Comment**:
changeset: 7042:f6a540e7b078
tag: tip
parent: 7037:9e8ca9d489a7
user: Vu Minh Nguyen <[email protected]>
date: Tue Oct 27 12:20:26 2015 +0100
summary: log: fix ownership of log files is not changed when group name is
changed [#1550]
rev: f6a540e7b078c353b2527a555eaaabde2ef3cc1c
changeset: 7041:fc15e05fff32
branch: opensaf-4.7.x
parent: 7038:51c09aee49cb
user: Vu Minh Nguyen <[email protected]>
date: Tue Oct 27 12:20:26 2015 +0100
summary: log: fix ownership of log files is not changed when group name is
changed [#1550]
rev: fc15e05fff32a408d070dbece69db0e74a5e2608
---
** [tickets:#1550] LOG: Ownership of log files is not changed when group name
is changed**
**Status:** fixed
**Milestone:** 4.7.0
**Created:** Fri Oct 16, 2015 11:57 AM UTC by elunlen
**Last Updated:** Fri Oct 23, 2015 08:46 PM UTC
**Owner:** nobody
When applying the groupname (IMM callback apply), group ownership shall be
changed for all existing log files. This will not happen since the function
that is supposed to do this job has not got the groupname so the operation will
fail. However the new groupname is correctly saved in the configuration store
and when new log files are created they will be given the correct ownership.
The handler function ‘own_log_files_by_group_hdl()’ uses the content of the
‘groupname’ member of the olfbgh_t structure with chown() but as you say this
variable is never set to any value in the corresponding lgs_own_log_files_h()
function.
The logDataGroupname_fileown() function (which is the only place where
lgs_own_log_files_h() is called) has the new group name as an in parameter but
there is no in parameter for giving this information to the
lgs_own_log_files_h() function.
In own_log_files_by_group_hdl() function ‘gid’ used with chown() is fetched
using function lgs_get_data_gid(). Originally this function was using the
groupname in the configuration store but now the groupname is an in parameter
to this function. Also groupname has been added to the olfbgh_t structure.
However passing this information to the lgs_own_log_files_h() and passing the
information own_log_files_by_group_hdl() to is missing.
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
