- **status**: review --> fixed
- **Comment**:
changeset: 7103:2ad93e45cf8b
branch: opensaf-4.6.x
tag: tip
parent: 7096:bdeee0a9e033
user: A V Mahesh <[email protected]>
date: Thu Nov 12 15:00:55 2015 +0530
summary: cpsv: validated SaTimeT timeout argument value for all CPA APIs
[#1583]
changeset: 7102:e6b54bdf7202
branch: opensaf-4.7.x
parent: 7095:9ce428fc53db
user: A V Mahesh <[email protected]>
date: Thu Nov 12 15:00:17 2015 +0530
summary: cpsv: validated SaTimeT timeout argument value for all CPA APIs
[#1583]
changeset: 7101:7b036d73636e
user: A V Mahesh <[email protected]>
date: Thu Nov 12 14:59:29 2015 +0530
summary: cpsv: validated SaTimeT timeout argument value for all CPA APIs
[#1583]
---
** [tickets:#1583] cpsv : saCkptCheckpointOpen open doesn't return if timeout
value is below the default CPSV_WAIT_TIME**
**Status:** fixed
**Milestone:** 4.6.2
**Created:** Wed Nov 04, 2015 04:40 AM UTC by A V Mahesh (AVM)
**Last Updated:** Fri Nov 06, 2015 05:59 AM UTC
**Owner:** A V Mahesh (AVM)
If we test upper & lower limits of `SaTimeT timeout` arguments to CPSV API ,
some of CPA API`s are doesn't returns
Current cpa code-doesn't validating/passing `SaTimeT timeout` arguments to
CPSV API , which are below default API timeout limit of CPSV_WAIT_TIME
(1400 * 10ms) and above `SaTimeT`, type long long int Maximum value
9223372036854775807 (2^63-1)
For example :
i) const SaTimeT timeout = 1215752192;
ii) const SaTimeT timeout = 2 * SA_TIME_ONE_MINUTE;
iii) const SaTimeT timeout = 9223372036854775809;
saCkptCheckpointOpen(...., timeout, ...);
Because of that in some of variables are over flowing and , API calls are not
working properly
Solution :
1 - need to validate if (time_out < CPSV_WAIT_TIME) return
SA_AIS_ERR_INVALID_PARAM
2- need to validate if (expirationTime < 0 ) return SA_AIS_ERR_INVALID_PARAM
3- Pass proper timeout values to internal functions of Opensaf
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.------------------------------------------------------------------------------
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
