---

** [tickets:#1696] imm: Endless loop in IMMND when admo marked as dying**

**Status:** accepted
**Milestone:** 5.0.FC
**Created:** Tue Mar 08, 2016 08:28 AM UTC by Hung Nguyen
**Last Updated:** Tue Mar 08, 2016 08:28 AM UTC
**Owner:** Hung Nguyen


If there's an admo marked as dying (mDying is true, discardNode() will not 
remove that admo from sOwnerVector.

~~~~
while(i2 != sOwnerVector.end()) {
    AdminOwnerInfo* ainfo = (*i2);
    if(ainfo->mNodeId == deadNode && (!ainfo->mDying)) {
        //Inefficient: lookup of admin owner again.
        if(adminOwnerDelete(ainfo->mId, true) == SA_AIS_OK) {
            i2 = sOwnerVector.begin();//restart of iteration again.
        } else { 
            LOG_WA("Could not delete admin owner %u %s", ainfo->mId,
                ainfo->mAdminOwnerName.c_str());
            ++i2;
        }
    } else { ++i2;}
}
~~~~

That makes the while() loop in isolateThisNode() never end.

~~~~
while(i2 != sOwnerVector.end()) {
    IdVector cv, gv;
    AdminOwnerInfo* ainfo = (*i2);
    otherNode = ainfo->mNodeId;
    if(otherNode == thisNode || otherNode == 0) {
        /* ??? (otherNode == 0) is that really correct ??? */
        i2++;
    } else {
        ainfo = NULL;
        this->discardNode(otherNode, cv, gv, isAtCoord);
        LOG_NO("Admo Discarded node %x", otherNode);
        /* Discard ccbs */

        i2 =  sOwnerVector.begin(); /* restart iteration. */
    }
}
~~~~

syslog will be flooded with this message
Feb 14 08:04:27 PL-61 osafimmnd[29149]: NO Admo Discarded node 2010f
Feb 14 08:04:27 PL-61 osafimmnd[29149]: NO Admo Discarded node 2010f
Feb 14 08:04:27 PL-61 osafimmnd[29149]: NO Admo Discarded node 2010f
Feb 14 08:04:27 PL-61 osafimmnd[29149]: NO Admo Discarded node 2010f
Feb 14 08:04:27 PL-61 osafimmnd[29149]: NO Admo Discarded node 2010f
Feb 14 08:04:27 PL-61 osafimmnd[29149]: NO Admo Discarded node 2010f
Feb 14 08:04:27 PL-61 osafimmnd[29149]: NO Admo Discarded node 2010f
Feb 14 08:04:27 PL-61 osafimmnd[29149]: NO Admo Discarded node 2010f
Feb 14 08:04:27 PL-61 osafimmnd[29149]: NO Admo Discarded node 2010f
Feb 14 08:04:27 PL-61 osafimmnd[29149]: NO Admo Discarded node 2010f


IMM cloud resilience ticket: [#1625]


---

Sent from sourceforge.net because [email protected] is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://makebettercode.com/inteldaal-eval
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

Reply via email to