---
** [tickets:#1870] rde: Fix cppcheck warnings**
**Status:** accepted
**Milestone:** 5.1.FC
**Created:** Thu Jun 09, 2016 08:26 AM UTC by Anders Widell
**Last Updated:** Thu Jun 09, 2016 08:26 AM UTC
**Owner:** Anders Widell
cppcheck version 1.74 reports the following warnings in the RDE service:
Line | Id | CWE | Severity | Message
---------- | ---------- | ------ | ------ | ------
osaf/libs/agents/infrastructure/rda/rda_papi.cc
300 | cstyleCast | 398 | style | C-style pointer casting
347 | redundantAssignment | 563 | style | Variable 'rc' is reassigned a value
before the old one has been used.
410 | redundantAssignment | 563 | style | Variable 'rc' is reassigned a value
before the old one has been used.
516 | pointerLessThanZero | 570 | style | A pointer can not be negative so it
is either pointless or an error to check if it is.
585 | redundantAssignment | 563 | style | Variable 'rc' is reassigned a value
before the old one has been used.
osaf/services/infrastructure/rde/include/role.h
34 | noExplicitConstructor | | style | Class 'Role' has a constructor with 1
argument that is not explicit.
34 | noExplicitConstructor | | style | Class 'Role' has a constructor with 1
argument that is not explicit.
34 | noExplicitConstructor | | style | Class 'Role' has a constructor with 1
argument that is not explicit.
34 | noExplicitConstructor | | style | Class 'Role' has a constructor with 1
argument that is not explicit.
34 | noExplicitConstructor | | style | Class 'Role' has a constructor with 1
argument that is not explicit.
34 | noExplicitConstructor | | style | Class 'Role' has a constructor with 1
argument that is not explicit.
osaf/services/infrastructure/rde/rde_mds.cc
240 | redundantAssignment | 563 | style | Variable 'rc' is reassigned a value
before the old one has been used.
osaf/services/infrastructure/rde/rde_rda.cc
374 | redundantAssignment | 563 | style | Variable 'sockfd' is reassigned a
value before the old one has been used.
417 | unusedFunction | | style | The function 'rde_rda_sock_name' is never
used.
473 | unusedFunction | | style | The function 'rde_rda_close' is never used.
osaf/tools/rde/rde_get_role.c
38 | redundantAssignment | 563 | style | Variable 'ret_val' is reassigned a
value before the old one has been used.
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
_______________________________________________
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
