Hi Gary,
One minor issue I am seeing when running long dn supported amf demo. Sysylog
says:
"The allocated memory is not large enough, the object will be truncated." This
is while sending a state change notification. Since su and si names are long
dn, length of additional text should be dynamically calcuated or increment to a
long fixed value.currenlty ntf.h defines it as:
\#define ADDITION_TEXT_LENGTH 320
Some minor comments and queries:
1) in avd_si_get(), trace leave should be above return statement.
2) In amfnd patches: Call to functions like amf_cbk_copy() from amfnd/util.cc
are replaced by there equivalents like avsv_amf_cbk_copy() from
osaf/libs/common/amf/n2avamsg.c.So these functions. I think. needs to be
cleaned. is there any reason of keeping them
3) In amfnd patches, memory allocation with 'new' operator is replaced with
calloc(). Any reason for doing this?
4) SInce new file amf_db_template.h is introduced, do we still need to keep old
db_template.h at amfd.
Thanks,
Praveen
---
** [tickets:#1642] AMF: Support DNs longer than 255 bytes**
**Status:** review
**Milestone:** 5.1.FC
**Created:** Tue Dec 15, 2015 09:52 AM UTC by Long HB Nguyen
**Last Updated:** Wed Aug 10, 2016 12:48 PM UTC
**Owner:** Long HB Nguyen
Ticket [#191] introduced generic support in OpenSAF for DNs longer than 255
bytes. Each individual OpenSAF service will also have to be adapted to support
long DNs. This ticket is for AMF to support this feature.
Moreover, this ticket also contains some enhancements:
1) Refactor internal SaNameT to std::string in amfd, amfnd.
2) Refactor PATRICIA trees to std::map in amfnd.
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
