- **status**: review --> fixed
- **Comment**:
opensaf-5.0.x:
changeset: 8438:5fba82ddf21f
branch: opensaf-5.0.x
parent: 8429:91b55c7c9848
user: Zoran Milinkovic <[email protected]>
date: Thu Dec 08 14:30:43 2016 +0100
summary: imm: move IMM error string prefixes to header file [#2198]
-----
opensaf-5.1.x:
changeset: 8439:62a68f4fb03a
branch: opensaf-5.1.x
parent: 8430:3f26fac74227
user: Zoran Milinkovic <[email protected]>
date: Thu Dec 08 14:30:43 2016 +0100
summary: imm: move IMM error string prefixes to header file [#2198]
-----
default(5.2):
changeset: 8440:805f11e83193
tag: tip
parent: 8437:1a479e952a20
user: Zoran Milinkovic <[email protected]>
date: Thu Dec 08 14:30:43 2016 +0100
summary: imm: move IMM error string prefixes to header file [#2198]
---
** [tickets:#2198] imm: Multiple definitions of IMM_VALIDATION_ABORT and
IMM_RESOURCE_ABORT**
**Status:** fixed
**Milestone:** 5.0.2
**Created:** Tue Nov 22, 2016 12:09 PM UTC by Anders Widell
**Last Updated:** Thu Dec 08, 2016 01:45 PM UTC
**Owner:** Zoran Milinkovic
The constants IMM_VALIDATION_ABORT and IMM_RESOURCE_ABORT are define at
multiple locations:
~~~
$ grep -r _ABORT immsv/|grep define
immsv/immnd/immnd_evt.c:#define IMM_VALIDATION_ABORT "IMM: Validation abort:
"
immsv/immnd/immnd_evt.c:#define IMM_RESOURCE_ABORT "IMM: Resource
abort: "
immsv/immnd/ImmModel.cc:#define IMM_VALIDATION_ABORT "IMM: Validation abort: "
immsv/immnd/ImmModel.cc:#define IMM_RESOURCE_ABORT "IMM: Resource abort: "
~~~
The definitions ought to be moved to one single header file, to avoid code
duplication and the risk of divergence (spelling mistakes in one of the
definitions but not the other, etc.).
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets