- **status**: review --> fixed
- **Comment**:
changeset: 8618:2e299171c00e
parent: 8616:e3262f91d56d
user: Anders Widell <[email protected]>
date: Fri Feb 24 15:39:57 2017 +0100
summary: base: Remove existing socket before creating a new one [#2293]
[staging:2e2991]
---
** [tickets:#2293] base: UnixSocket, multiple issues**
**Status:** fixed
**Milestone:** 5.2.FC
**Created:** Tue Feb 07, 2017 03:19 PM UTC by Anders Widell
**Last Updated:** Fri Feb 10, 2017 02:35 PM UTC
**Owner:** Anders Widell
Multiple issues have been identified in the UnixSocket class:
* The UnixServerSocket fails if the named already exists in the file system.
* The UnixSocket uses a mutex to protect Open() and Close(), but this is not
enough to make it thread safe. The suggestion is to remove the mutex and let
users protect the instance if needd
* The fd() method is not so useful since it requires a message to be sent or
received before it returns a valid file descriptor. It is probably better if
the fd() method opens the socket if it is not already open.
* The UnixClientSocket implements a wait-loop in case connect() returns
EINPROGRESS. It would be better to us a blocking call to connect().
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets