---
** [tickets:#2326] log : fix all cpp check issues **
**Status:** assigned
**Milestone:** next
**Created:** Mon Feb 27, 2017 03:40 AM UTC by A V Mahesh (AVM)
**Last Updated:** Mon Feb 27, 2017 03:40 AM UTC
**Owner:** A V Mahesh (AVM)
2017-02-24 10:18:04 INFO: *** List of cppcheck errors added by patch ***
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::amfSelectionObject' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::amf_hdl' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::amf_invocation_id' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::async_upd_cnt' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::ckpt_state' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::clmSelectionObject' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::clm_hdl' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::clm_init_sel_obj' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::comp_name' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::edu_hdl' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::fully_initialized' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::ha_state' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::immOiHandle' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::immSelectionObject' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::is_quiesced_set' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::last_client_id' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::lga_down_list_head' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::lga_down_list_tail' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::log_version' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::mbcsv_ckpt_hdl' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::mbcsv_hdl' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::mbcsv_peer_version' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::mbcsv_sel_obj' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::mds_hdl' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::mds_role' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::nid_started' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::scAbsenceAllowed' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_cb.h:106]: (warning) Member
variable 'lgs_cb::vaddr' is not initialized in the constructor.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_clm.cc:137]: (style) The
scope of the variable 'clm_node' can be reduced.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_clm.cc:213]: (style) The
scope of the variable 'rec' can be reduced.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_clm.cc:220]: (performance)
Prefer prefix ++/-- operators for non-primitive types.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_evt.cc:1493]: (style)
Condition '0' is always false
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_evt.cc:163]: (error)
Mismatching allocation and deallocation: client
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_evt.cc:168]: (error)
Mismatching allocation and deallocation: client
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_evt.cc:344]: (performance)
Prefer prefix ++/-- operators for non-primitive types.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_evt.cc:416]: (style) The
scope of the variable 'ckpt_ptr' can be reduced.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_evt.cc:417]: (style) The
scope of the variable 'async_rc' can be reduced.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_evt.cc:532]: (style) The
scope of the variable 'temp_lga_down_rec' can be reduced.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_evt.cc:553]: (style) The
scope of the variable 'stream' can be reduced.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_evt.cc:671]: (style) The
scope of the variable 'ckpt_ptr' can be reduced.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_evt.cc:672]: (style) The
scope of the variable 'header_ptr' can be reduced.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_mbcsv.cc:1112]: (style)
Condition '0' is always false
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_mbcsv.cc:1148] ->
[src/log/logd/lgs_mbcsv.cc:1125]: (style) Variable 'rc' is reassigned a value
before the old one has been used.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_mbcsv.cc:1671]: (style)
Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or
'setitimer' instead.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_mbcsv.cc:1875]: (style)
Checking if unsigned variable 'clientId' is less than zero.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_mbcsv.cc:711]: (performance)
Prefer prefix ++/-- operators for non-primitive types.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_mbcsv.cc:767]: (performance)
Function parameter 'edu_hdl' should be passed by reference.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_mbcsv.cc:941] ->
[src/log/logd/lgs_mbcsv.cc:938]: (style) Variable 'rc' is reassigned a value
before the old one has been used.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_mbcsv.cc:985]: (style)
Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or
'setitimer' instead.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_util.cc:363]: (performance)
Prefer prefix ++/-- operators for non-primitive types.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_util.cc:521]: (style) The
function 'lgs_check_path_exists_h' is never used.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_util.cc:566]: (portability)
Non reentrant function 'getgrnam' called. For threadsafe applications it is
recommended to use the reentrant replacement function 'getgrnam_r'.
2017-02-24 10:18:04 INFO: *** [src/log/logd/lgs_util.cc:912]: (performance)
Prefer prefix ++/-- operators for non-primitive types.
----------
'2017-02-23 13:44:28,233 INFO - *** List of cppcheck errors added by patch ***'
'2017-02-23 13:44:28,233 INFO - *** [src/log/logd/lgs_filehdl.cc:577]:
(style) Variable 'len' is assigned a value that is never used.'
'2017-02-23 13:44:28,233 INFO - *** [src/log/logd/lgs_stream.cc:1337]:
(style) Unsigned variable 'id' can't be negative so it is unnecessary to test
it.'
'2017-02-23 13:44:28,234 INFO - *** [src/log/logd/lgs_stream.cc:1350]:
(style) The scope of the variable 'tmp' can be reduced.'
'2017-02-23 13:44:28,234 INFO - *** [src/log/logd/lgs_stream.cc:1447]:
(style) The function 'log_stream_id_print' is never used.'
'2017-02-23 13:44:28,234 INFO - *** [src/log/logd/lgs_stream.cc:408]:
(style) The function 'log_free_stream_resources' is never used.'
'2017-02-23 13:44:28,234 INFO - *** [src/log/logd/lgs_stream.cc:416]:
(warning) Assignment of function parameter has no effect outside the function.
Did you forget dereferencing it?'
'2017-02-23 13:44:28,235 INFO - *** [src/log/logd/lgs_stream.cc:533]:
(portability) Non reentrant function 'strtok' called. For threadsafe
applications it is recommended to use the reentrant replacement function
'strtok_r'.'
'2017-02-23 13:44:28,235 INFO - *** [src/log/logd/lgs_stream.cc:852]:
(style) Obsolescent function 'usleep' called. It is recommended to use
'nanosleep' or 'setitimer' instead.'
'2017-02-23 13:44:28,235 INFO - *** [src/log/logd/lgs_stream.cc:869]:
(style) Obsolescent function 'usleep' called. It is recommended to use
'nanosleep' or 'setitimer' instead.'
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
