This should default to ON because it is part of the spec.
Having AMF deal with this (instead of SMF) now allows someone to change this
behavior in the middle of a campaign. This can be dangerous. Do we really want
to allow this?
---
** [tickets:#2435] amf: make auto repair restriction optional**
**Status:** review
**Milestone:** 5.17.06
**Created:** Thu Apr 20, 2017 10:22 AM UTC by Gary Lee
**Last Updated:** Fri Apr 21, 2017 07:42 AM UTC
**Owner:** Gary Lee
Ticket #2144 added support for restricting auto-repair in accordance to the AMF
spec. However, it has become clear some applications have relied on the legacy
auto-repair behaviour. We now have a backwards compatibility issue. Therefore
we should make the auto-repair restriction behavior optional, and make it
default to the legacy haviour.
It is proposed to make this behaviour configurable via an attribute in a new
AMF configuration object.
'''
diff --git a/src/amf/config/amf_classes.xml b/src/amf/config/amf_classes.xml
index ee0f185..d082990 100644
--- a/src/amf/config/amf_classes.xml
+++ b/src/amf/config/amf_classes.xml
@@ -1438,4 +1438,20 @@
<flag>SA_WRITABLE</flag>
</attr>
</class>
+ <class name="OpenSafAmfConfig">
+ <category>SA_CONFIG</category>
+ <rdn>
+ <name>amfConfig</name>
+ <type>SA_STRING_T</type>
+ <category>SA_CONFIG</category>
+ <flag>SA_INITIALIZED</flag>
+ </rdn>
+ <attr>
+ <name>amfRestrictAutoRepairEnable</name>
+ <type>SA_UINT32_T</type>
+ <category>SA_CONFIG</category>
+ <flag>SA_WRITABLE</flag>
+ <default-value>0</default-value>
+ </attr>
+ </class>
</imm:IMM-contents>
diff --git a/src/amf/config/amf_objects.xml b/src/amf/config/amf_objects.xml
index 502fc2f..31fc3e5 100644
--- a/src/amf/config/amf_objects.xml
+++ b/src/amf/config/amf_objects.xml
@@ -1,5 +1,12 @@
<?xml version="1.0" encoding="utf-8"?>
<imm:IMM-contents xmlns:imm="http://www.saforum.org/IMMSchema";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:noNamespaceSchemaLocation="SAI-AIS-IMM-XSD-A.02.13.xsd">
+ <object class="OpenSafAmfConfig">
+ <dn>amfConfig=1,safApp=safAmfService</dn>
+ <attr>
+ <name>amfRestrictAutoRepairEnable</name>
+ <value>0</value>
+ </attr>
+ </object>
<object class="SaAmfAppBaseType">
<dn>safAppType=OpenSafApplicationType</dn>
</object>
'''
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
