Going for a short vacation, here is the untested patch. Use rebootTimeout to 
increase the timeout for it.

commit 2ffbd1c5cd3f4193fd631130eef60b17c92892e6 (HEAD -> ticket-2499)
Author: Rafael Odzakow <[email protected]>
Date:   Tue Jun 20 16:10:12 2017 +0200

    smf: 20 seconds timeout in getting node destination is not enough [#2499]

diff --git a/src/smf/smfd/SmfUpgradeStep.cc b/src/smf/smfd/SmfUpgradeStep.cc
index 2ffeab110..a99c7661a 100644
--- a/src/smf/smfd/SmfUpgradeStep.cc
+++ b/src/smf/smfd/SmfUpgradeStep.cc
@@ -1966,7 +1966,7 @@ bool SmfUpgradeStep::callActivationCmd() {
   TRACE("Get node destination for %s", getSwNode().c_str());
   uint32_t rc;

-  if (!getNodeDestination(getSwNode(), &nodeDest, NULL, -1)) {
+  if (!waitForNodeDestination(getSwNode(), &nodeDest)) {
     LOG_NO("no node destination found for node %s", getSwNode().c_str());
     result = false;
     goto done;



---

** [tickets:#2499] SMF: 20 seconds timeout in getting node destination is not 
enough**

**Status:** unassigned
**Milestone:** 5.17.08
**Created:** Fri Jun 16, 2017 08:04 AM UTC by Tai Dinh
**Last Updated:** Tue Jun 20, 2017 03:03 AM UTC
**Owner:** nobody


We're now using a hard coded timeout value (20 seconds) in getting node 
destination.
This is sometimes not enough especially in cluster reboot procedure. Controller 
may come up first and continue the campaign without waiting for the rest to be 
up.
This can make the getNodeDestination() fail sometimes, especially for a large 
cluster.
In our case, it needs 3 more seconds.

I guess this timeout need to be increased or should be configurable.
Reuse some existing attribute for this purpose is also fine, e.g: 
smfRebootTimeout.

/Tai


---

Sent from sourceforge.net because [email protected] is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

Reply via email to