- **status**: accepted --> review


---

** [tickets:#2594] AMF: Improve SC status change callback**

**Status:** review
**Milestone:** 5.17.10
**Created:** Tue Sep 26, 2017 02:34 AM UTC by Quyen Dao
**Last Updated:** Tue Sep 26, 2017 02:39 AM UTC
**Owner:** Quyen Dao


The SC status change callback declaration/definition is not consistent with 
other AMF callbacks.

1) It doesn't have an alias for callback type (defined by typdef) as the others

~~~
extern SaAisErrorT osafAmfInstallSCStatusChangeCallback(
     SaAmfHandleT amfHandle,
     void (*OsafAmfSCStatusChangeCallbackT)(OsafAmfSCStatusT status));
~~~

2) Callback name is not correct. It should not end with T as it's not a type

`static void (*OsafAmfSCStatusChangeCallbackT)(OsafAmfSCStatusT state);`

Beside that the current declaration/definition of SC status change call may 
cause issue for the script that automatically generates the python AIS 
interface in #2471 as it's not consistent with other AMF callbacks


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

Reply via email to