- **status**: review --> fixed
- **assigned_to**: Canh Truong -->  nobody 
- **Comment**:

commit 9638ef3c50fa94036203c97fb382c3dba758e39b (HEAD, origin/develop, develop)
Author: Canh Van Truong <[email protected]>
Date:   Mon Sep 18 15:49:03 2017 +0700

    log: fix incorrect handling of version when initializing OpenSAF APIs 
[#2516]

    The version used when initializing the API is in many cases stored in a 
global
    variable and this global variable is used every time the API is initialized.
    The version is given as a pointer to this variable. The problem is that this
    variable is defined as an [in/out] parameter that gives the version to use 
when
    initializing [in] but the value shall be changed by the agent to the highest
    version supported by the initialized service [out]. This means that the next
    time the API is initialized it may be initialized with a higher version.

    This patch help to fix that always initialize OpenSaf API with correct 
version
    in log service.




---

** [tickets:#2516] log: Incorrect handling of version when initializing OpenSAF 
APIs**

**Status:** fixed
**Milestone:** 5.17.10
**Created:** Fri Jun 30, 2017 12:49 PM UTC by elunlen
**Last Updated:** Mon Sep 18, 2017 11:28 AM UTC
**Owner:** nobody


A general problem when initializing OpenSAF APIs is found. This problem applies 
to all OpenSAF services.

The version used when initializing the API is in many cases stored in a global 
variable and this global variable is used every time the API is initialized. 
The version is given as a pointer to this variable. The problem is that this 
variable is defined as an [in/out] parameter that gives the version to use when 
initializing [in] but the value shall be changed by the agent to the highest 
version supported by the initialized service [out]. This means that the next 
time the API is initialized it may be initialized with a higher version. A 
higher version may not be backwards compatible with the intended version. Even 
if this is not causing any problems now it may in the future when new features 
are added.

An example is IMM that has a highest version A, 2, 18. If this version is used 
IMM will handle CLM nodes in a different way than if initialized with a lower 
version. For example, new return codes has to be handled.



---

Sent from sourceforge.net because [email protected] is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

Reply via email to