It can also been seen that 'avd_count_node_up' sometimes incorrectly includes 
the standby SC in its count.


<143>1 2018-10-29T15:57:00.642283+11:00 SC-1 osafamfd 265 osafamfd [meta 
sequenceId="6593"] 265:amf/amfd/ndfsm.cc:216 >> avd_count_node_up 
<143>1 2018-10-29T15:57:00.642289+11:00 SC-1 osafamfd 265 osafamfd [meta 
sequenceId="6594"] 265:amf/amfd/ndfsm.cc:226 TR Number of node director(s) that 
director received node_up msg:0
<143>1 2018-10-29T15:57:00.642292+11:00 SC-1 osafamfd 265 osafamfd [meta 
sequenceId="6595"] 265:amf/amfd/ndfsm.cc:228 << avd_count_node_up 
<143>1 2018-10-29T15:57:00.642307+11:00 SC-1 osafamfd 265 osafamfd [meta 
sequenceId="6598"] 265:amf/amfd/ndfsm.cc:348 TR Received node_up_msg from 
node:safAmfNode=SC-1,safAmfCluster=myAmfCluster. Start/Restart  NodeSync timer 
waiting for remaining (3) node(s)
<143>1 2018-10-29T15:57:00.642311+11:00 SC-1 osafamfd 265 osafamfd [meta 
sequenceId="6599"] 265:amf/amfd/ndfsm.cc:535 << avd_node_up_evh 
<143>1 2018-10-29T15:57:01.560426+11:00 SC-1 osafamfd 265 osafamfd [meta 
sequenceId="11026"] 265:amf/amfd/ndfsm.cc:296 >> avd_node_up_evh: from 2020f, 
safAmfNode=SC-2,safAmfCluster=myAmfCluster
<143>1 2018-10-29T15:57:01.560459+11:00 SC-1 osafamfd 265 osafamfd [meta 
sequenceId="11029"] 265:amf/amfd/ndfsm.cc:216 >> avd_count_node_up 
<143>1 2018-10-29T15:57:01.560469+11:00 SC-1 osafamfd 265 osafamfd [meta 
sequenceId="11030"] 265:amf/amfd/ndfsm.cc:226 TR Number of node director(s) 
that director received node_up msg:1




---

** [tickets:#2946] amfd: set node_sync_window_closed when timer is stopped**

**Status:** review
**Milestone:** 5.18.12
**Created:** Thu Oct 25, 2018 10:36 AM UTC by Gary Lee
**Last Updated:** Mon Oct 29, 2018 04:28 AM UTC
**Owner:** Gary Lee


When testing split network partitions, sometimes AMFD gets into a loop 
processing messages below. Eventually it is aborted by the watchdog.

2018-10-25 16:41:43.051 SC-1 osafamfd[272]: NO Receive message with event 
type:13, msg_type:32, from node:2030f, msg_id:0
2018-10-25 16:41:43.052 SC-1 osafamfd[272]: NO Receive message with event 
type:12, msg_type:31, from node:2030f, msg_id:0
2018-10-25 16:41:43.052 SC-1 osafamfd[272]: NO Receive message with event 
type:13, msg_type:32, from node:2030f, msg_id:0
2018-10-25 16:41:43.052 SC-1 osafamfd[272]: NO Receive message with event 
type:12, msg_type:31, from node:2030f, msg_id:0
2018-10-25 16:41:43.052 SC-1 osafamfd[272]: NO Receive message with event 
type:13, msg_type:32, from node:2030f, msg_id:0
2018-10-25 16:41:43.052 SC-1 osafamfd[272]: NO Receive message with event 
type:12, msg_type:31, from node:2030f, msg_id:0
2018-10-25 16:41:43.053 SC-1 osafamfd[272]: NO Receive message with event 
type:13, msg_type:32, from node:2030f, msg_id:0
2018-10-25 16:41:43.053 SC-1 osafamfd[272]: NO Receive message with event 
type:12, msg_type:31, from node:2030f, msg_id:0
2018-10-25 16:41:43.053 SC-1 osafamfd[272]: NO Receive message with event 
type:13, msg_type:32, from node:2030f, msg_id:0
2018-10-25 16:41:43.053 SC-1 osafamfd[272]: NO Receive message with event 
type:12, msg_type:31, from node:2030f, msg_id:0
2018-10-25 16:41:43.054 SC-1 osafamfd[272]: NO Receive message with event 
type:13, msg_type:32, from node:2030f, msg_id:0

This fixes it. AMF didn't expect any more sync messages after all nodes have 
synced. But a PL split from the main network partition will also send a 
headless sync msg.

diff --git a/src/amf/amfd/ndfsm.cc b/src/amf/amfd/ndfsm.cc
index c460d8f..1bc6ed9 100644
--- a/src/amf/amfd/ndfsm.cc
+++ b/src/amf/amfd/ndfsm.cc
@@ -357,6 +357,7 @@ void avd_node_up_evh(AVD_CL_CB *cb, AVD_EVT *evt) {
       if (cb->node_sync_tmr.is_active) {
         avd_stop_tmr(cb, &cb->node_sync_tmr);
         TRACE("stop NodeSync timer");
+        cb->node_sync_window_closed = true;
       }
       cb->all_nodes_synced = true;
       LOG_NO("Received node_up_msg from all nodes");



---

Sent from sourceforge.net because [email protected] is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

Reply via email to