- **status**: review --> fixed
- **Comment**:
commit f8a6848a1cdbff0b518c3db951e4689e260226c7 (HEAD -> develop,
origin/develop, ticket-2943)
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Mon Nov 5 11:29:12 2018 +0700
imm: fix coredump generated during roaming test [#2943]
The fix of ticket [#2934] was not covered the roaming SC case.
With roaming, IMMND veteran could run on system controller node type.
Instead of going to accept_node directly in previous fix, it should go to
update_node_type.
---
** [tickets:#2943] imm: coredump is generated during roaming test**
**Status:** fixed
**Milestone:** 5.18.12
**Created:** Tue Oct 23, 2018 02:49 AM UTC by Vu Minh Nguyen
**Last Updated:** Tue Oct 23, 2018 04:37 AM UTC
**Owner:** Vu Minh Nguyen
**Attachments:**
-
[bt_core.1539905156.osafimmd.196.SC-2](https://sourceforge.net/p/opensaf/tickets/2943/attachment/bt_core.1539905156.osafimmd.196.SC-2)
(16.5 kB; application/octet-stream)
I missed handling the roaming SC case in the ticket [#2934] . Instead of going
to `accept_node` directly, it should go to `update_node_type`. With roaming,
IMMND veteran could run on system controller node type.
diff --git a/src/imm/immd/immd_evt.c b/src/imm/immd/immd_evt.c
index 9cd82da64..a0f632b7e 100644
— a/src/imm/immd/immd_evt.c
+++ b/src/imm/immd/immd_evt.c
@@ -1814,7 +1814,7 @@ static uint32_t immd_evt_proc_immnd_intro(IMMD_CB *cb,
IMMD_EVT *evt,
cb->ccb_id_count,
msg->ccb_id_count,
cb->impl_count, msg->impl_count);
}
- goto accept_node;
+ goto update_node_type;
}
if (cb->fevsSendCount < evt->info.ctrl_msg.fevs_count)
{ @@ -1887,6 +1887,7 @@ static uint32_t immd_evt_proc_immnd_intro(IMMD_CB *cb,
IMMD_EVT *evt, }
}
+update_node_type:
/* Determine type of node. */
if (sinfo->dest == cb->loc_immnd_dest) {
node_info->isOnController = true;
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list._______________________________________________
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
