- **status**: review --> fixed
- **Part**: - --> lib
- **Milestone**: future --> 5.19.10
- **Comment**:

commit 7d6bf312c4a965e12b99c7a784a8e81cc7618a03
Author: Minh Chau <[email protected]>
Date:   Sat Sep 21 01:56:37 2019 +1000

    mds: Update code from comments [#1960]

commit 95cc2539c675565da41238a954a8ab87307081a1
Author: Thuan Tran <[email protected]>
Date:   Thu Sep 19 10:04:05 2019 +1000

    mds: Add TIPC buffer overflow for mdstest [#1960]

commit 460f2789c1f57ee657f11784426fb01949bc93cf
Author: Minh Chau <[email protected]>
Date:   Thu Sep 19 10:04:05 2019 +1000

    mds: Apply serial number arithmetic for sequence counter [#1960]
    
    This patch applies the serial number arithmetic for the flow control
    sequence number, referenced to RFC1982.
    
    This is only temporary patch, a proper one could be made in /base
    with template for others type, e.g uint32. Then mds reuses it from
    /base.

commit f0a222b94363a4d08fb49982d2e2dddab0c305c0
Author: Minh Chau <[email protected]>
Date:   Thu Sep 19 10:04:05 2019 +1000

    mds: Add configurable parameters [#1960]
    
    This patch makes the solution of TIPC buffer overflow configurable,
    as well as the ack timeout/ack size.
    For example:
    The service config file can export the following environment variables
    
    export MDS_TIPC_FCTRL_ENABLED=1
    export MDS_TIPC_FCTRL_ACKTIMEOUT=1000
    export MDS_TIPC_FCTRL_ACKSIZE=1
    
    If MDS_TIPC_FCTRL_ACKTIMEOUT, MDS_TIPC_FCTRL_ACKSIZE are not specified,
    the default values are used.

commit 25f47c7fe1960c21e8026f83955a89fb24036e6b
Author: Minh Chau <[email protected]>
Date:   Thu Sep 19 10:04:05 2019 +1000

    mds: Implement kRcvBuffOverflow state [#1960]
    
    This patch implements the kRcvBuffOverflow state machine as
    described in README file.

commit 064a2affd7cf010c2c1e21476121a305ac985151
Author: Minh Chau <[email protected]>
Date:   Thu Sep 19 10:04:05 2019 +1000

    mds: Add state machine for tipc portid instance [#1960]
    
    This patch adds state machine to support tx probation timer.

commit 507637f598e124dced28fc376fa100f9cd1f270c
Author: Minh Chau <[email protected]>
Date:   Thu Sep 19 10:04:05 2019 +1000

    mds: Add timeout for ack message [#1960]
    
    If the ack size is configured greater than 1, there should be a timeout
    at receiver ends to send the ack message back to senders.
    The ack message timeout utilizes the poll timeout in flow control thread
    to make mds lightweight (in contrast to additional timer threads).

commit ea8a2a643ffb05cb3fb05a3cc0b53784fa953a39
Author: Minh Chau <[email protected]>
Date:   Thu Sep 19 10:04:05 2019 +1000

    mds: Add implementation for TIPC buffer overflow solution [#1960]
    
    This is a collaborative patch of two participants:Thuan, Minh.
    
    Main changes:
    - Add mds_tipc_fctrl_intf.h, mds_tipc_fctrl_intf.cc: These two files
    introduce new functions which are called in mds_dt_tipc.c if the flow
    control is enabled
    - Add mds_tipc_fctrl_portid.h, mds_tipc_fctrl_portid.cc: These files
    implements the tipc portid instance, which supports the sliding window,
    mds msg queue
    - Add mds_tipc_fctrl_msg.h, mds_tipc_fctrl_msg.cc: These files define
    the event and messages which are used for this solution.

commit 31968fe50bd62fc3d86a93c53cba6e25d83aee8b
Author: Thuan Tran <[email protected]>
Date:   Thu Sep 19 10:04:05 2019 +1000

    mds: Resolve c/c++ linking issue [#1960]
    
    This patch solves the linking issue if mds_dt.h or mds_core.h
    is included in c++ sources.

commit 890b49096978ae1419b240599de9aa2cffb7368a
Author: Minh Chau <[email protected]>
Date:   Thu Sep 19 10:04:05 2019 +1000

    mds: Add README for solution of TIPC buffer overflow at MDS [#1960]




---

** [tickets:#1960] MDS: MDS does not handle dropped TIPC packages **

**Status:** fixed
**Milestone:** 5.19.10
**Created:** Fri Aug 19, 2016 08:39 AM UTC by Hans Nordebäck
**Last Updated:** Mon Sep 02, 2019 12:55 AM UTC
**Owner:** Minh Hon Chau


TIPC is run in connection less mode by OpenSAF, i.e. SOCK_RDM, reliable 
datagram where ordering is guaranteed but packages can be dropped at e.g. 
overload situations.
This is not handled by OpenSAF and may cause undetermined behaviour in the 
system.




---

Sent from sourceforge.net because [email protected] is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

Reply via email to