- **status**: accepted --> review
---
** [tickets:#3294] mds: refactor huge api functions**
**Status:** review
**Milestone:** future
**Created:** Tue Oct 26, 2021 06:02 AM UTC by Hieu Hong Hoang
**Last Updated:** Tue Feb 08, 2022 05:09 AM UTC
**Owner:** Hieu Hong Hoang
Some functions have 1.5K+ line of code. It's hard to maintain those functions.
We should refactor it into smaller sub-functions.
For example:
~~~
line 1863: uint32_t mds_mcm_svc_up(PW_ENV_ID pwe_id, MDS_SVC_ID svc_id,
V_DEST_RL role,
line 1864: NCSMDS_SCOPE_TYPE scope, MDS_VDEST_ID vdest_id,
line 1865: NCS_VDEST_TYPE vdest_policy, MDS_DEST adest,
line 1866: bool my_pcon, MDS_SVC_HDL local_svc_hdl,
line 1867: MDS_SUBTN_REF_VAL subtn_ref_val,
line 1868: MDS_SVC_PVT_SUB_PART_VER svc_sub_part_ver,
line 1869: MDS_SVC_ARCHWORD_TYPE archword_type)
line 1870: {
....
line 3494: }
~~~
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list._______________________________________________
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
