--- Martin Paljak wrote:
Do a checkout of the SVN projects, do your modifications, run svn  
diff, save the output to a file, send it to the mailinglist as an  
attachment with a short description what is fixed.
--- end of quote ---
Ok, I've put in some code to deal with a few leaks.

I have a question, though, looking at pkcs11_load_cert and pkcs11_load_key.

PKCS11_enumerate_slots gets called fairly high up in both of these
functions...this call allocates memory for a list of PKCS11_SLOTs.  It looks to
me like, in a lot of error cases, these slots are not released, and this memory
isn't allocated.  I'd be happy to clean that up, but I just want to be sure that
I'm not missing something here...maybe there's a reason for that stuff to stick
around?

If it looks like this is something that should be fixed, I'll put that code in
and submit my patch all together.

Thanks!
Chris Masone
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to