On 25/04/06, Andreas Jellinghaus <[EMAIL PROTECTED]> wrote:
> I found a few issues with gtkcard, please
> review attached patch.
>
> 1.) enrollInfo in CreateWindows.c is malloc'ed and filled
> but never used.
Exact.
> 2.) P11.c has several off by one error. one is fixed with
> setting j to 31, but two lines below that tokenString[32]
> is also off by one.
Line 50 we have:
char itokenString[33];
so tokenString[32] is valid (even if a bit surprising)
A better idea would be to replace 32 by sizeof(tokenString)-1.
> 3.) newObject is not free()d in error handling parts.
> malloc'ing it later solves that issue.
Exact.
Feel free to commit your patches.
Thanks,
--
Dr Ludovic Rousseau
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel
