On 26/04/06, Andreas Jellinghaus <[EMAIL PROTECTED]> wrote:
> not sure the code is now 100% correct.
> the old code looks wrong to me, it could have
> let towards accessing a buffer beyond its length.

I don't see what the bug was. The problem was with memcpy()?

> but: do we need to add some error handling for
> the case that the len >apdu->rsplen?
> or do we silently assume the apdu has either a buffer
> big enough, or no buffer at all?

I suggest to log the error and return SC_ERROR_BUFFER_TOO_SMALL.

Bye,

--
 Dr. Ludovic Rousseau
_______________________________________________
opensc-devel mailing list
[email protected]
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to