On Fri, Dec 01, 2006 at 11:16:26PM +0100, Andreas Jellinghaus wrote:
> Peter Stuge wrote:
> >On Thu, Nov 30, 2006 at 10:28:14PM +0100, Andreas Jellinghaus wrote:
> >>the typedefs are not conditional or anything, so there is no
> >>difference if we uee "unsigned char" directly in that function
> >
> >Until it has to be changed in many places instead of one because
> >unsigned char isn't 8 bit anymore. Maybe we should even make nice
> >uint8_t and friends?
> 
> well, if unsigned char is not 8bit everywher, then changing it from
> unsigned char to uint8_t would break the api. the api defined in
> the official rsa header files uses "unsigned char" and we want to
> stay compatible with that, right?

The standard says "an unsigned 8-bit value" right before the CK_BYTE
typedef. It doesn't say explicitly what to do if unsigned char is
something else, but I would make sure that it stays "an unsigned
8-bit value" rather than making sure it's typedef to unsigned char.
But never mind, this is all hypothetical. We'll fix it when we have
to.


//Peter
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to