2007/11/12, Douglas E. Engert <[EMAIL PROTECTED]>:
> The ATR above is listed in  as one of the gemexpresso_atrs[].  It looks
> like you added it to the SVC, as it was not in Dave's original source.

I added this ATR. It correspond to the card I have.

> All the other card routines use  sc_pkcs15emu_add_pin_obj
> but pkcs15-gemsafeV1.c is using a stic version of sc_pkcs15emu_add_pin
> that calls sc_pkcs15emu_add_object. I don't see a problem here,
> but could it use sc_pkcs15emu_add_pin_obj instead?

I reused some routines from the file pkcs15-sync.c released with
OpenSC 0.9.6. These functions are no more present in version 0.11.x.
It was just a cut-n-paste without any rework. So bugs/problems are expected.

I did this just to have a compilable and half working OpenSC for
testing. Thanks for your feedback.

> Minor point, the routines card-gemsafeV1.c, pkcs15-gemsafeGPK.c
> and pkcs15-gemsafeV1.c are the only source files with uppercase letters.
> For consistency, and maybe problems with Windows, could these be lowercase?

It should not harm unless we also have a file pkcs15-gemsafegpk.c

Note that Mac OS X default filesystem is also case insensitive.

Bye

-- 
  Dr. Ludovic Rousseau
_______________________________________________
opensc-devel mailing list
[email protected]
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to