Peter Stuge wrote: > On Thu, Apr 03, 2008 at 05:02:24PM -0500, Douglas E. Engert wrote: >> The first problem deals with the rutoken modules which define many >> duplicate names. It appears some code was copied from the Windows >> header file: WinCrypt.h > > .. > >> Both rutoken and WinCrypt.h define: _RSAPUBKEY, RSAPUBKEY, >> _PUBLICKEYSTRUC, PUBLICKEYSTRUC and BLOBHEADER. It looks like the >> structures where copied from the winCrypt.h and BYTE replaced with >> u8, WORD replaced with uint16_t, and DWORD replaced with unin32_t. > > Clearly the author did not investigate how to properly make the > code portable.
There is also the question of copying the source. > > >> Its not clear what should be done with the code. > > Possibly it could be restructured, but pending that patch why not > simply protect the structure definitions with #ifndef, either on each > struct or simply a WIN32 flag. I was reluctant to make any changes, as the code is new, and I was expecting the authors of this code to respond and to make the changes. I see that Alon has made some changes. I will try it again. > > > //Peter > _______________________________________________ > opensc-devel mailing list > [email protected] > http://www.opensc-project.org/mailman/listinfo/opensc-devel > > -- Douglas E. Engert <[EMAIL PROTECTED]> Argonne National Laboratory 9700 South Cass Avenue Argonne, Illinois 60439 (630) 252-5444 _______________________________________________ opensc-devel mailing list [email protected] http://www.opensc-project.org/mailman/listinfo/opensc-devel
