Ludovic Rousseau wrote: > On Thu, Aug 28, 2008 at 1:02 AM, Huie-Ying Lee <[EMAIL PROTECTED]> wrote: > >> Douglas E. Engert wrote: >> >>> This sounds like an interesting change. But could it be reworked to >>> allow the use of either the slot_num or the slot_description? >>> (But not both.) This would then avoid all the #ifdef SUN_SOLARIS >>> and make the mod more general, and easier to test. >>> >>> >> This sounds like a good suggestion. In fact, I was also thinking about >> this arrangement prior to submit this patch. >> I will go ahead to make the enhancement and resummit the patch. >> > > Good. > > Do not change the Makefile.am to add -DSUN_SOLARIS. You should add any > plateform specific flag using "./configure CPPFLAFS=-DSUN_SOLARIS". > > Adding -DSUN_SOLARIS in Makefile.am is just a temporary workaround. I tried to find a proper way, but failed to do so. Your suggestion is perfect. Thanks.
Huie-Ying > But the problem will solve itself since you will rewrite your patch to > avoid all the #ifdef SUN_SOLARIS > > Bye > > _______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
