>Hi, > >the license needs to be in english, so I can understand what it says.
Ok, I will put it in English. > >currently opensc is under LGPL 2.1+ and we accept code under that license >(and BSD3). > >Starting to mix different licenses within one library is not a good idea >I think. so if you want to submit the code as LGPL 3.0+, then we should >discuss if we want to switch opensc to LGPL 3.0+ for the next major >release or not. if we agree to do that we can accept the code, but we >should discuss this first openly, not change the de facto license situation >without dicussion. > It's a mistake from me, I put translated licence that I use elsewhere. > >other than that the code looks ok, except minor formatting issues >(we use unix line ends with utf-8 or ascii encoding, not iso8859-1 >or windows line ends). but that could be fixed with recode. > >Some lines are quite long, while it is nice to have max. 80 chars >or even use Lindent (aka indent -npro -kr -i8 -ts8 -sob -l80 -ss -ncs) >that is not required and some code is made quite ugly with it, >so we haven't found the perfect way to make the code look nice and >keep it readable). Yes I will correct this. > >except for these the code looks good. > >Regards, Andreas François. _______________________________________________ opensc-devel mailing list [email protected] http://www.opensc-project.org/mailman/listinfo/opensc-devel
