On 11.09.2009, at 14:30, Aktiv Co. Aleksey Samsonov wrote: > Hello. > I propose a patch for src/libopensc/card-westcos.c to fix some > compiler warnings and coding style and remove code duplication, but > unfortunately I can't test it. > Patch for trunk revision 3718.
Were these the only functions that were overlapping ISO functionality? As a general note, committing new dead code (#if 0 style) should not be done. There are some historic instances still present in the code which should also be reaped out. +1 for the patch. I also have questions about westcos-tool and if some of it's functions can't be implemented via pkcs15init interface (like -G)? Some places still need more English. -- Martin Paljak http://martin.paljak.pri.ee +372.515.6495 _______________________________________________ opensc-devel mailing list [email protected] http://www.opensc-project.org/mailman/listinfo/opensc-devel
