A few things I noticed: * latest changes martin made to slot/reader logic etc. will break your code. martin, can you help to port it to latest trunk? * the reader driver for the card module: maybe it would be clearer if it had a file of its own? or does it share code with the pcsc reader driver? not sure what is best. * Makefile.am: it would be better to the new source files always, and simply have a big #ifdef around the whole code. that way tar.gz files will include the new code files without extra logic needed in the makefiles. * the card module: if we re-arrange the libraries (details still under discussion), it might be better to put that code into some other directory, or maybe a new one? maybe the code will want to use pkcs15init functions one day, so libopensc/ wouldn't be a good place then. * linking: it might be easier for all users, if we create a fat binary at least with all opensc parts included (i.e. not linking libopensc as shared library), and maybe also statically link other shared libs used (I guess only libcrypto and libltdl)). at least I think library hell has been an issue, so if there is a single binary that needs to be placed in system32 (or some other place), that is much easier, than if it depends on more dlls. (also unix library revisions don't map well to windows, so several apps with their own copy of openssl don't play well I guess...)
> - Look at pin management and certificate/private key link to improve. I saw some references to pin caching IIRC. not sure if that was the new stuff we now use or the old stuff martin throw out (we had two or three parts of the code doing more or less the same thing), so there could be issues / merge problems. martin, can you have a look? > - Improve register key management and .inf file to manage all cards (with > options to not manage some cards) - Documentation hmm. a simple gui app could help users to manage that. but no idea what an easy way to write a simple gui is on windows these days. or maybe a nice installer package instead? we had a nsis installer once... documentation: could be placed in the wiki, maybe with the first line telling users: this functionality will be available with opensc 0.12.* so current users are not confused. Regards, Andreas _______________________________________________ opensc-devel mailing list [email protected] http://www.opensc-project.org/mailman/listinfo/opensc-devel
