Looks great.
Unfortunately there is a bug opened in nsis that forbid running on
64bit, so I cannot test it.

You can commit it if you like to maintain this...

Few notes:

1.
+if [ "${BUILD_FOR_WINDOWS}" = "1" ]; then
should be:
[ -n "${BUILD_FOR_WINDOWS}" ] && nsis

2. Why we need the .in file? Can't makensis accept variable from cmdline?

3. Can you please put all nsis related files in nsis/ directory or similar?

4. Don't you like to install the csp?

Thanks!

On Wed, Feb 10, 2010 at 2:07 PM, François Leblanc
<francois.lebl...@cev-sa.com> wrote:
>
> Alon,
>
> What do you think about this patch to create installable release .
>
> Something like this can be ok ?
>
> (I don't have makensis on my linux developement server but I have it on my 
> windows client and I
> Run it on script generated and get it working.)
>
> Regards,
> François.
>
>
> _______________________________________________
> opensc-devel mailing list
> opensc-devel@lists.opensc-project.org
> http://www.opensc-project.org/mailman/listinfo/opensc-devel
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to