>hmm, why move internal.h? what is in internal.h that changes the winreg.h 
>include?

Winreg.h depends of definition in windows.h witch is included in
internal.h...

>usually it is not internal.h that has some special define, but config.h,
>and we have that as first include everywhere. so if there is something
>special in internal.h that I missed, I would like to know :)

Perhaps config.h should include windows.h in case of _WIN32 ? Don't know
if it's the correct solution (and possible). In doubt I keep the actual 
code but change doesn't mind me.

>also it would be good to add a comment with these specifics, so we
>have this special case documented in the source code.

Yes even though for windows developpment it's not 'specifics' since
all start with windows.h, it's confirm that it will be fine to have
it in config.h like said up.

>Thanks, Andreas

Regards,
François.

Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
opensc-devel mailing list
[email protected]
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to