I don't understand why you changed the default value of verbose
from "0" to "-1". it only leeds to more complex code paths in many
places.

if you don't want to verwrite ctx->debug (fine with me), a
single line change like this:
-       ctx->debug = verbose;
+       if (verbose) ctx->debug = verbose;
would be enough.

did I miss some subtil reason for the "-1" default?

also I think, if the code is changed, it should be done in all
tools, not only pkcs15-tool and pkcs15-init.

Andreas
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to