2010/8/16 Emanuele Pucciarelli <[email protected]>:
> Hi Kalev,
>
>> gcc warns about a potential buffer overflow:
>
> […]
>
> Thanks! I'll fix that in both places (lines 540 and 552).
>
> To be honest, no overflow should ever happen, as the label is always a
> static string; nevertheless, those lines are ugly, and I think gcc is
> right in complaining about that. :)

Maybe a better approach would be to use strlcat [1] instead of strncat.
We already have strlcpy in src/common/compat_strlcpy.[h,c]

I can provide the implementation I use in pcsc-lite.

Bye

[1] http://en.wikipedia.org/wiki/Strlcpy

-- 
 Dr. Ludovic Rousseau
_______________________________________________
opensc-devel mailing list
[email protected]
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to