webmas...@opensc-project.org wrote: > Revision: 4692 > Author: martin > Date: 2010-09-05 16:53:08 +0000 (Sun, 05 Sep 2010) > > Log Message: > ----------- > pkcs11: #250: refresh PIN counters and associated token flags on every call > to C_GetTokenInfo > > Modified: trunk/src/pkcs11/framework-pkcs15.c > +CK_RV C_GetTokenInfo(CK_SLOT_ID slotID, CK_TOKEN_INFO_PTR pInfo) > > Modified: trunk/src/pkcs11/pkcs11-global.c > -CK_RV C_GetTokenInfo(CK_SLOT_ID slotID, CK_TOKEN_INFO_PTR pInfo) >
I do not agree with this change. Why to spoil the old house, when we are not yet ready to build a new one? Certainly, inside the opensc-pkcs11, like in the stomach, all in one place, but I guess that somebody can be sensible to the order of arrival. In this changes the common 'C_' function is defined inside the 'framework-pkcs15' when 'framework-pkcs15init' is still there. With the same logic we can start to define the common libopensc functions inside the card drivers. Why not? At the end of course all this stuff will be inside the same library. IMHO, first of all the re-design of frameworks has to be done in atomic manner, then the upper changes. Kind wishes, Viktor. -- Viktor Tarasov <viktor.tara...@opentrust.com> _______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
