Hello, On Sep 23, 2010, at 11:37 AM, Umberto Rustichelli aka Ubi wrote: > I see the function parse_slot_id_string in engine_pkcs11.c ends with: > > /* ... or "label_" */ > if (strncmp(slot_id + i, "label_", 6) == 0) > *slot = n; > return (*label = strdup(slot_id + i + 6)) != NULL; > > fprintf(stderr, "could not parse string!\n"); > return 0; > > in my humble opinion, that is potentially wrong, probably > the intention was to write a parenthesis after the if, > to enclose the return (indenting confirms the intention!)
Thanks, fixed [1] [1] http://www.opensc-project.org/engine_pkcs11/changeset/129 -- @MartinPaljak.net +3725156495 _______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
