Hello,
Douglas E. Engert wrote:
> Great for now. But in SVN pkcs15-sec.c:188,189:
>
> 187 switch (obj->type) {
> 188 /* FIXME -DEE GOSTR is misusing the sc_card_find_rsa_alg */
> 189 case SC_PKCS15_TYPE_PRKEY_GOSTR3410:
> 190 case SC_PKCS15_TYPE_PRKEY_RSA:
> 191 modlen = prkey->modulus_length / 8;
> 192 alg_info = sc_card_find_rsa_alg(p15card->card, prkey
>
> This should be fixed sometime, as the GOSTR code is depending on
> the RSA alg_info. But GOSTR should have sc_card_find_gostr_alg
> and _sc_card_add_gostr_alg routines. In card-rtecp.c there are calls
> to _sc_card_add_rsa_alg for 256, 512, 768, (look way to weak for RSA)
> It look like they were added because pkcs15-sec.c:192 is only looking
> at RSA. So in pkcs15-sec.c above, it is looking at the alg_info created
> by the call at card-rtecp.c:73 _sc_card_add_rsa_alg(card, 256, flags, 0);
Agree. Fixed at 4931. Thanks!
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel
