On Thu, 2011-02-03 at 14:04 -0600, Douglas E. Engert wrote:
> I have updates #321 with a new version of the cardmod patch
> and would like to start to commit it in pieces.
> 
> Piece 1 is the attachment I sent on 1/28 as new.martin.patch
> based on Martin's patch from 1/19. This was the patch that would
> work for Brian. The main change is adding two parameters to all
> the *_detect_readers routines.  Martin's patch already required these
> to be added in a number of places.
> 
> Is there any objection to adding this patch now?

Yes, why you want to call 'sc_context_create()' altogether. There is not
much functionality in it. So you could easily implement the required
initialisation in 'CardAcquireContext()'.

Next point is reader-pcsc.c: Why do you belief that squeezing in a
second driver namely cardmod is a good idea? Why not implement a new
one? Read the documents provided by Microsoft. Most things are managed
by the CSP framework and therefore a reader-cardmod would be straight
forward consisting mostly of stub functions.

To make things short: Not calling 'sc_context_create()' and implementing
a new reader-driver would make your proposal obsolete.

Regards
Andre

_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to