On Mar 25, 2011, at 20:35 , Viktor TARASOV wrote: > Le 25/03/2011 19:22, Martin Paljak a écrit : >> On Mar 25, 2011, at 20:19 , webmas...@opensc-project.org wrote: >> >>> Revision: 5271 >>> Author: vtarasov >>> Date: 2011-03-25 18:19:28 +0000 (Fri, 25 Mar 2011) >>> >>> Log Message: >>> ----------- >>> cardmod: when getting serial number use GET_SERIAL ctl call ... >>> >>> rather then card->serialnr value. Not all card drivers initialize this >>> member. >> >> Feel free to file a bug for this as well, to make sure that >> active/"compliant" drivers would implement it consistently. > > Ok, but can it really be considered as bug ? > Using the 'GET_SERIAL' ctl looks like more 'canonical' way to get serial > number at the libopensc level . > > There are three or four drivers that do not initialize this member .
Not a *bug* but a thing that should be fixed. For a single data field or common operation a single method should exist. So that things like this GUID generation would work and there would not be a parallel redundant and thus useless implementation. The interface between "core" and drivers must be universal and consistently implemented by drivers. _______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
