2011/6/7 Martin Paljak <mar...@martinpaljak.net> > > Hello, > On Jun 7, 2011, at 11:48 , Ludovic Rousseau wrote: > > > Hello, > > > > My first git contribution [1] :-) > > " Fix compiler warning > > > > Declare the function static to fix: > > pkcs15-lib.c:1069: warning: no previous prototype for > > 'sc_pkcs15init_encode_prvkey_content' " > > > > What is the preferred way to submit patches? > > - reference them on github or another public git server (as I just did) > > - attach them in the email (easier for review) > > - both > > I would say either link or link + patches. Or only patches if there's > nowhere to link. But eventually it would be necessary to pull the changes > from somewhere, either by cherry-picking or from a branch (preferred) or from > mail attachments (would be nice to avoid if possible). Adding the patch files > to the e-mail would probably be good as well (if/when github.com would go > down or lose history or changes URL layout etc). Mailing list archive is one > of the most valuable assets of a project communication medium, IMHO. > > As github allows to comment on patches and pull requests to single line > granularity, having a link to some "gitweb" style location would be preferred.
OK. So what should I do now with my patch? It looks like the "official" repository is still svn on opensc-project.org. Should I commit my git patch on svn? > > Note: I don't know how to generate patch files since I committed and > > pushed my changes to github. > > You can use "git format-patch HEAD~2" to generate patch files in the current > folder for last two commits. Thanks. Patch attached. -- Dr. Ludovic Rousseau
0001-Fix-compiler-warning.patch
Description: Binary data
_______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
