Le 26 mars 2012 17:27, "Magosányi, Árpád" <m4g...@gmail.com> a écrit : > Would https://www.opensc-project.org/codereview/#/c/263/ also fall to > the "Commits that obviously should be bundled with some other change" > category? > Half of the changes needed is at > https://www.opensc-project.org/codereview/#/c/262/1, and the two or > three lines being the main point has been changed between the two patches.
And https://www.opensc-project.org/codereview/#/c/263/ is incomplete/bogus. Very good job at reviewing the patch. Thanks. > And I am still confused by the place of gerrit in the development > procedure. Maybe it is rtfm, then please point me to the fm. > I see the patch in gerrit, its fate seems to be undecided for me, but > the corresponding bug report is "fixed" as the patch got to staging. The changes have been merged (by me) on github but not yet on gerrit. The 2 repositories (github and gerrit) have diverged and it is problematic. I think Martin is working on a merge of the 2 repositories. But I don't know what to do if a patch is accepted on github and then rejected on gerrit. Gerrit should be the only entry for patches to avoid such problems. Bye -- Dr. Ludovic Rousseau _______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
